gap-packages / JupyterKernel

Native Jupyter kernel for GAP
https://gap-packages.github.io/JupyterKernel/
BSD 3-Clause "New" or "Revised" License
19 stars 12 forks source link

TikZ splash now uses png; demos and documentation added #136

Open pedritomelenas opened 1 month ago

pedritomelenas commented 1 month ago

TikZ now uses png (via pdftoppm). In this way it outputs correctly both on linux and macos. Also, github notebook previewer shows the graphics properly.

Documentation for JupyterSplashDot and JupyterSplashTikZ added.

Demo notebooks for dot (with numericalsgps) and tikz (with intpic) added.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 13.95349% with 37 lines in your changes missing coverage. Please review.

Project coverage is 26.00%. Comparing base (34b60ec) to head (773752e).

Files with missing lines Patch % Lines
gap/JupyterUtil.gi 5.55% 34 Missing :warning:
gap/JupyterRenderable.gi 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #136 +/- ## ========================================== - Coverage 26.14% 26.00% -0.14% ========================================== Files 14 14 Lines 876 892 +16 ========================================== + Hits 229 232 +3 - Misses 647 660 +13 ``` | [Files with missing lines](https://app.codecov.io/gh/gap-packages/JupyterKernel/pull/136?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages) | Coverage Δ | | |---|---|---| | [gap/JupyterRenderable.gd](https://app.codecov.io/gh/gap-packages/JupyterKernel/pull/136?src=pr&el=tree&filepath=gap%2FJupyterRenderable.gd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages#diff-Z2FwL0p1cHl0ZXJSZW5kZXJhYmxlLmdk) | `100.00% <100.00%> (ø)` | | | [gap/JupyterUtil.gd](https://app.codecov.io/gh/gap-packages/JupyterKernel/pull/136?src=pr&el=tree&filepath=gap%2FJupyterUtil.gd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages#diff-Z2FwL0p1cHl0ZXJVdGlsLmdk) | `100.00% <100.00%> (ø)` | | | [gap/JupyterRenderable.gi](https://app.codecov.io/gh/gap-packages/JupyterKernel/pull/136?src=pr&el=tree&filepath=gap%2FJupyterRenderable.gi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages#diff-Z2FwL0p1cHl0ZXJSZW5kZXJhYmxlLmdp) | `65.51% <25.00%> (-5.32%)` | :arrow_down: | | [gap/JupyterUtil.gi](https://app.codecov.io/gh/gap-packages/JupyterKernel/pull/136?src=pr&el=tree&filepath=gap%2FJupyterUtil.gi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages#diff-Z2FwL0p1cHl0ZXJVdGlsLmdp) | `6.73% <5.55%> (-2.65%)` | :arrow_down: |
pedritomelenas commented 1 month ago

Added also some warnings if any of the intermediate steps to create the png (pdflatex+pdftoppm+pdfinfo+base64) fails.