time variable does not work

gap-packages / JupyterKernel

Native Jupyter kernel for GAP

https://gap-packages.github.io/JupyterKernel/

BSD 3-Clause "New" or "Revised" License

19 stars 12 forks source link

time variable does not work #39

Closed ssiccha closed 5 years ago

ssiccha commented 6 years ago

It shows e.g. 11 ms if a command ran for a few seconds.

markuspf commented 6 years ago

I see the following options to address this problem:

1) Remove access to time (because I am not sure it serves a useful purpose, anyway, and it certainly becomes even less useful if you run things in a container) 2) make time reflect the time it took to execute the cell 3) have timing for every statement in the cell

for options 2 or three I am happy to explain how to approach this for a pull request to appear.

olexandr-konovalov commented 6 years ago

+1 for option 2

olexandr-konovalov commented 6 years ago

Came across this while working on a demo I intend to give this week. @markuspf do you have any tips for option 2 then?

markuspf commented 5 years ago

This is resolved with 85e9fc2f73aa1476c0890191f2aa4a8942c70dfc

olexandr-konovalov commented 5 years ago

Thanks - close it then?