codecov[bot]
commented
5 years ago Codecov Report
Merging #79 into master will increase coverage by
1.32%. The diff coverage is100%.
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 63.31% 64.64% +1.32%
==========================================
Files 9 8 -1
Lines 886 710 -176
==========================================
- Hits 561 459 -102
+ Misses 325 251 -74| Impacted Files | Coverage Δ | |
|---|---|---|
| gap/JupyterKernel.gi | 77.91% <100%> (ø) |
:arrow_up: |
| gap/JupyterStream.gi | 42.5% <0%> (-2.5%) |
:arrow_down: |
GAP introduced a global variable ERROR_OUTPUT which stores the file or stream that GAP prints the error messages to.
With this the hack in JupyterError.gi can be removed.
This PR assumes that gap-system/gap#2824 will be backported to 4.10. Otherwise this needs a hack to be backwards compatible with 4.10.