gap-packages / NautyTracesInterface

Interface from GAP to Nauty
https://gap-packages.github.io/NautyTracesInterface/
Other
6 stars 6 forks source link

Tests should ignore whitespace #28

Closed jamesjer closed 5 years ago

jamesjer commented 5 years ago

I just tried to build git head on an x86_64 Fedora Rawhide machine, with gap 4.10.2. The test suite reports a failure:

########> Diff in /builddir/build/BUILDROOT/gap-pkg-nautytracesinterface-0.2-1\
0.20190912git7a658d8.fc32.x86_64/usr/lib/gap/pkg/nautytracesinterface/tst/test\
.tst:1
# Input is:
Petersen := Graph( SymmetricGroup(5), [[1,2]], OnSets,
                  function(x,y) return Intersection(x,y)=[]; end );
# Expected output:
rec( adjacencies := [ [ 3, 5, 8 ] ], 
  group := Group([ (1,2,3,5,7)(4,6,8,9,10), (2,4)(6,9)(7,10) ]), 
  isGraph := true, 
  names := [ [ 1, 2 ], [ 2, 3 ], [ 3, 4 ], [ 1, 3 ], [ 4, 5 ], [ 2, 4 ], 
      [ 1, 5 ], [ 3, 5 ], [ 1, 4 ], [ 2, 5 ] ], order := 10, 
  representatives := [ 1 ], schreierVector := [ -1, 1, 1, 2, 1, 1, 1, 1, 2, 2 
     ] )
# But found:
rec( adjacencies := [ [ 3, 5, 8 ] ], group := Group([ (1,2,3,5,7)
  (4,6,8,9,10), (2,4)(6,9)(7,10) ]), isGraph := true, 
  names := [ [ 1, 2 ], [ 2, 3 ], [ 3, 4 ], [ 1, 3 ], [ 4, 5 ], [ 2, 4 ], 
      [ 1, 5 ], [ 3, 5 ], [ 1, 4 ], [ 2, 5 ] ], order := 10, 
  representatives := [ 1 ], schreierVector := [ -1, 1, 1, 2, 1, 1, 1, 1, 2, 2 
     ] )
########

As you can see, the output really is the same, except for whitespace. I think this line in tst/testall.g:

TestDirectory(dirs, rec(exitGAP := true));

should be changed to this:

TestDirectory(dirs, rec(exitGAP := true, testOptions := rec(compareFunction := "uptowhitespace")));

Indeed, making that change led to a successful test suite run.