search

gap-packages / PatternClass

Exploring permutation pattern classes build by token passing networks
https://gap-packages.github.io/PatternClass/
GNU General Public License v2.0
5 stars 3 forks source link

Patches for automata package? #24

Open fingolfin opened 1 year ago

fingolfin commented 1 year ago

README.md says

We had to patch the IntersectionAutomaton, UnionAutomata and ProductLanguage from the Automata pkg (version 1.13) to improve performance testing. The patched functions are located in lib/automata.* .

Are you really patching functions? I see no trace for that; rather it seems you provide alternative functions with different name?

either way: would it make sense to contribute these changes back to the automata package, which is also hosted here on GitHub

ruthhoffmann commented 1 year ago

At the time the decision was made to create a new function which does the same thing but correctly and renamed it (otherwise there were clashes).

I agree, I shall create an issue on the automata pkg repo.

ruthhoffmann commented 1 year ago

https://github.com/gap-packages/automata/issues/15

Submitted the issue above. I didn't want to submit a PR as there might be a good reason why the automata authors are doing the minimisation or turning the automata deterministic at the beginning of the Intersection, Union and Product functions.

ruthhoffmann commented 4 weeks ago

Union and Intersection has now been patched in automata v1.16. I still need to investigate Product.