gap-packages / QuimpGrp

GAP database of quasiprimitive imprimitive permutation groups of degree at most 4095
Other
0 stars 0 forks source link

Don't use `EvalString` #4

Closed fingolfin closed 6 months ago

fingolfin commented 2 years ago

It has many problems and should not be used in production code if at all possible.

Things like EvalString( Concatenation( "QUIMP_", String(deg) ) ) can probably be replaced by ValueGlobal( Concatenation( "QUIMP_", String(deg) ) ). Even better would be to instead use the language feature that is meant for this, and instead use a big array/list indexed by the degree -- as I understand it, it'll have at most 4095 entries, so its size should be no problem. (Though if it was, one can also index records by integers, and use them as a kind of "spare array" this way)