search

gap-packages / Thelma

GAP Package on threshold logic.
https://gap-packages.github.io/Thelma
Other
1 stars 2 forks source link

Do not call `LoadPackage( "gauss", ... )' in the package file #13

Closed olexandr-konovalov closed 5 years ago

olexandr-konovalov commented 5 years ago

The following issue is reported in test logs:

#I  Thelma: Do not call `LoadPackage( "gauss", ... )' in the package file
#I          /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packagesload/label/kovacs/GAP-pkg-update-stable-snapshot/pkg/Thelma-1.02/lib/internal_functions.gi,
#I          use `IsPackageMarkedForLoading' instead
vlaver commented 5 years ago

The following issue is reported in test logs:

#I  Thelma: Do not call `LoadPackage( "gauss", ... )' in the package file
#I          /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packagesload/label/kovacs/GAP-pkg-update-stable-snapshot/pkg/Thelma-1.02/lib/internal_functions.gi,
#I          use `IsPackageMarkedForLoading' instead

Done, made the corresponding changes.

olexandr-konovalov commented 5 years ago

Thanks. I looked at b6a4c3bf1f232a00a5fd843df1eaea190295f402 and actually you don't need that line at all since Gauss is a required package.

Also IsPackageMarkedForLoading is not used that way. It returns a boolean and does not perform any action.

vlaver commented 5 years ago

"you don't need that line at all" - deleted it, sorry.

olexandr-konovalov commented 5 years ago

Closed by d8698fd5112385181c3c3e1665225913db821f48 - thanks