search

gap-packages / Thelma

GAP Package on threshold logic.
https://gap-packages.github.io/Thelma
Other
1 stars 2 forks source link

Version 1.01 -> 1.02 #9

Closed vlaver closed 5 years ago

olexandr-konovalov commented 5 years ago

The gauss package requires compilation. The current version also works without it, but slower. The version included in GAP 4.9 fails to load without it at all. You need to modify .travis.yml to ensure that gauss package will also be compiled: add to it the line with GAP_PKGS_TO_BUILD as shown below:

language: c
env:
  global:
    - GAPROOT=gaproot
    - COVDIR=coverage
    - GAP_PKGS_TO_BUILD="gauss io profiling"
...
olexandr-konovalov commented 5 years ago

I have also edited the title of the PR to make it more informative - please edit it further if you wish.

codecov[bot] commented 5 years ago

Codecov Report

Merging #9 into master will decrease coverage by 3.83%. The diff coverage is 78.3%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   58.76%   54.93%   -3.84%     
==========================================
  Files          12       14       +2     
  Lines        2459     3215     +756     
==========================================
+ Hits         1445     1766     +321     
- Misses       1014     1449     +435
Impacted Files Coverage Δ
lib/mvthrel.gd 100% <ø> (ø)
lib/threl_def.gd 100% <ø> (ø) :arrow_up:
lib/mvthrel.gi 90.78% <ø> (ø)
lib/boolfunc_def.gd 100% <100%> (ø) :arrow_up:
lib/iterative_methods.gd 100% <100%> (ø) :arrow_up:
lib/neural_network.gd 100% <100%> (ø) :arrow_up:
lib/ste_realizability.gd 100% <100%> (ø) :arrow_up:
lib/ste_realizability.gi 35.51% <41.3%> (-0.56%) :arrow_down:
lib/internal_functions.gi 78.14% <65.98%> (-2.18%) :arrow_down:
lib/iterative_methods.gi 24.77% <74.6%> (-9.07%) :arrow_down:
... and 10 more
codecov[bot] commented 5 years ago

Codecov Report

Merging #9 into master will decrease coverage by 3.83%. The diff coverage is 78.3%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   58.76%   54.93%   -3.84%     
==========================================
  Files          12       14       +2     
  Lines        2459     3215     +756     
==========================================
+ Hits         1445     1766     +321     
- Misses       1014     1449     +435
Impacted Files Coverage Δ
lib/mvthrel.gd 100% <ø> (ø)
lib/threl_def.gd 100% <ø> (ø) :arrow_up:
lib/mvthrel.gi 90.78% <ø> (ø)
lib/boolfunc_def.gd 100% <100%> (ø) :arrow_up:
lib/iterative_methods.gd 100% <100%> (ø) :arrow_up:
lib/neural_network.gd 100% <100%> (ø) :arrow_up:
lib/ste_realizability.gd 100% <100%> (ø) :arrow_up:
lib/ste_realizability.gi 35.51% <41.3%> (-0.56%) :arrow_down:
lib/internal_functions.gi 78.14% <65.98%> (-2.18%) :arrow_down:
lib/iterative_methods.gi 24.77% <74.6%> (-9.07%) :arrow_down:
... and 10 more
olexandr-konovalov commented 5 years ago

GAP problem fixed. Restarted the build, but now Gauss package fails to build in stable-4.9 branch. Since we have GAP 4.10 release already, I suggest to remove 

    - env: GAPBRANCH=stable-4.9

from .travis.yml and also require

  GAP := ">= 4.10",

in PackageInfo.g, You can not guarantee backwards compatibility with older releases, and for a new packages this is not critical.