search

gap-packages / ace

GAP interface for the the Advanced Coset Enumerator (ACE)
https://gap-packages.github.io/ace/
MIT License
3 stars 6 forks source link

Mark functions that do not return in a standard way #31

Closed jamesjer closed 2 years ago

jamesjer commented 2 years ago

All 3 of al2_continue, al2_restart, and al2_abort do not return in the normal way (they use longjmp to exit). Instead of using a gcc-specific attribute to indicate this property, this change uses _Noreturn for C11 compilers and [[noreturn]] for C23 compilers, which has the benefit for working for non-GCC compilers as well.

Note that GCC added support for _Noreturn in GCC 4.7. Even RHEL 7, one of the older enterprise Linuxes, currently ships GCC 4.8. It is not easy in 2022 to find a GCC so old that it does not support C11.

codecov[bot] commented 2 years ago

Codecov Report

Merging #31 (641b118) into master (24d45e9) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   39.02%   39.00%   -0.02%     
==========================================
  Files          10       10              
  Lines        2760     2761       +1     
==========================================
  Hits         1077     1077              
- Misses       1683     1684       +1
Impacted Files Coverage Δ
gap/interact.gi 24.20% <0.00%> (-0.02%) :arrow_down: