search

gap-packages / anupq

The ANUPQ GAP package
https://gap-packages.github.io/anupq/
Artistic License 2.0
4 stars 6 forks source link

close the stream in `PqDescendants` #65

Closed ThomasBreuer closed 1 month ago

ThomasBreuer commented 2 months ago

otherwise the process is still running, and calling PqDescendants too many times will result in a "failed to launch child process" error in PQ_START.

ThomasBreuer commented 1 month ago

@fingolfin Perhaps this fix (or a better one) would also be interesting for the forthcoming GAP release.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.59%. Comparing base (75eca36) to head (b010b25). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #65 +/- ## ========================================== + Coverage 16.55% 16.59% +0.04% ========================================== Files 146 146 Lines 12835 12838 +3 Branches 1934 1934 ========================================== + Hits 2125 2131 +6 + Misses 10706 10703 -3 Partials 4 4 ``` | [Files with missing lines](https://app.codecov.io/gh/gap-packages/anupq/pull/65?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages) | Coverage Δ | | |---|---|---| | [lib/anupga.gi](https://app.codecov.io/gh/gap-packages/anupq/pull/65?src=pr&el=tree&filepath=lib%2Fanupga.gi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages#diff-bGliL2FudXBnYS5naQ==) | `29.10% <100.00%> (+1.19%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/gap-packages/anupq/pull/65/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages)