search

gap-packages / anupq

The ANUPQ GAP package
https://gap-packages.github.io/anupq/
Artistic License 2.0
4 stars 6 forks source link

Require GMP and take GAP's GMP_PREFIX into account #66

Closed fingolfin closed 1 month ago

fingolfin commented 1 month ago

There is no good reason to allow building anupq without GMP these days. On the downside, if one fails to do that (which may happen without the user even knowing what happened), one may get unexpected errors or perhaps even wrong results. So better to just require this.

This also simplifies the logic in configure.ac considerably, and allows us to just use the same as in anunq.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 17.17%. Comparing base (368ec0b) to head (fc2d923). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #66 +/- ## ========================================== + Coverage 16.71% 17.17% +0.46% ========================================== Files 146 145 -1 Lines 12840 12737 -103 Branches 1936 1929 -7 ========================================== + Hits 2146 2188 +42 + Misses 10686 10539 -147 - Partials 8 10 +2 ``` [see 15 files with indirect coverage changes](https://app.codecov.io/gh/gap-packages/anupq/pull/66/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages)