Closed fingolfin closed 4 years ago
Merging #8 into master will not change coverage. The diff coverage is
90%
.
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 16 16
Lines 179708 179708
=======================================
Hits 165925 165925
Misses 13783 13783
Impacted Files | Coverage Δ | |
---|---|---|
gap/sqrt.gi | 77.07% <90%> (ø) |
:arrow_up: |
SqrtField_objectify
usingBindGlobal
type
argument ofSqrtField_objectify
, it is always SqrtFieldTypeelm
argument toSqrtField_objectify
: so instead ofSqrtField_objectify([x])
, now writeSqrtField_objectify(x)
Objectify
. This is trivial to achieve thanks to the previous point.Note that passing immutable objects as second argument to
Objectify
was always illegal in GAP, but due to a bug this restriction was not properly enforced. As a result, code accidentally passing in immutable objects silently worked. Future versions of GAP will issue a warning for this, and one distant day perhaps even an error.In the meantime, this patch prepares corelg for this eventuality, and even if that day never comes, it does no harm either.