codecov[bot]
commented
4 years ago Codecov Report
Merging #9 into master will decrease coverage by
<.01%. The diff coverage is100%.
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 92.33% 92.33% -0.01%
==========================================
Files 16 16
Lines 179708 179707 -1
==========================================
- Hits 165925 165924 -1
Misses 13783 13783| Impacted Files | Coverage Δ | |
|---|---|---|
| gap/sqrt.gd | 100% <100%> (ø) |
:arrow_up: |
The main (only?) reason to use this combination is one needs to read in code which references the variable before one can possible define the variable. That's is not the case here.
On the GAP side, there are various issues with
InstallValue, so on the long run, some of us are thinking about replacing it with a better mechanism. While it is not yet clear whether this will happen at all, and in which form, avoiding its use in corelg means one place less we (the GAP team) have to worry about it :-)