gap-packages / cryst

Computing with crystallographic groups

https://www.math.uni-bielefeld.de/~gaehler/gap/packages.php#Cryst

Other

3 stars 6 forks source link

Avoid use of DeclareGlobalVariable / InstallValue #16

Closed fingolfin closed 3 years ago

fingolfin commented 4 years ago

Instead just use BindGlobal. For motivation of this change, please see https://github.com/gap-system/gap/pull/3857

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will decrease coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   94.31%   94.31%   -0.01%     
==========================================
  Files          23       23              
  Lines        7563     7561       -2     
==========================================
- Hits         7133     7131       -2     
  Misses        430      430

Impacted Files	Coverage Δ
grp/spacegrp.gd	`100% <ø> (ø)`	:arrow_up:
grp/spacegrp.grp	`100% <100%> (ø)`	:arrow_up: