search

gap-packages / cryst

Computing with crystallographic groups
https://www.math.uni-bielefeld.de/~gaehler/gap/packages.php#Cryst
Other
3 stars 6 forks source link

Please separate Tests that use CrystCat #21

Closed narc-Ontakac2 closed 3 years ago

narc-Ontakac2 commented 4 years ago

Some tests use functions from crystcat. As a result running the tests for cryst depends on crystcat which depends on cryst. This is bad for debian packaging, where as a result building gap-cryst requires gap-cryst to be installed.

Since I am packaging gap-cryst I have made a patch that separates the tests using crystcat and only runs them if crystcat can be loaded. You might want to apply it. tst-split.txt

olexandr-konovalov commented 3 years ago

Thanks @narc-Ontakac2 - the patch looks correct to me, and I think it's a good idea, hopefully @gaehler also agrees. If you'd like to submit a PR, please go ahead!