gap-packages / fr

GAP package for functionally recursive (automata) groups in GAP
https://gap-packages.github.io/fr/
Other
5 stars 14 forks source link

Broken tests in version 2.4.1 #19

Closed olexandr-konovalov closed 7 years ago

olexandr-konovalov commented 7 years ago

The following happens while testing the package with the GAP stable-4.8 branch:

============================OUTPUT START==============================

#I  RunPackageTests("fr", "2.4.1", "tst/testall.g", auto);
 ���������������������������   GAP unknown of 2017-03-06 13:07:58 (GMT)
 ���  GAP  ���   https://www.gap-system.org
 ���������������������������   Architecture: x86_64-pc-linux-gnu-gcc-default64
 Libs used:  gmp, readline
 Loaded workspace: wsp.g
 Components: trans 1.0, prim 2.1, small* 1.0, id* 1.0
 Packages:   ACE 5.2, AClib 1.2, Alnuth 3.0.0, AtlasRep 1.5.1, AutPGrp 1.8, 
             Browse 1.8.6, CRISP 1.4.4, Cryst 4.1.12, CrystCat 1.1.6, 
             CTblLib 1.2.2, FactInt 1.5.4, FGA 1.3.1, FR 2.4.1, GAPDoc 1.5.1, 
             GBNP 1.0.3, IO 4.4.6, IRREDSOL 1.3.1, LAGUNA 3.7.0, lpres 0.4.1, 
             nq 2.5.3, Polenta 1.3.7, Polycyclic 2.11, RadiRoot 2.7, 
             ResClasses 4.6.0, Sophus 1.23, SpinSym 1.5, TomLib 1.2.6, 
             Utils 0.46
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
#I  ReadTest is no longer supported. Please use more robust and flexible
#I  Test. For backwards compatibility, ReadTest(<filename>) is replaced
#I  by Test( <filename>, rec( compareFunction := "uptowhitespace" ))
fr:chapter 12
GAP4stones: 300000000
#I  ReadTest is no longer supported. Please use more robust and flexible
#I  Test. For backwards compatibility, ReadTest(<filename>) is replaced
#I  by Test( <filename>, rec( compareFunction := "uptowhitespace" ))
fr:chapter 3
GAP4stones: 1020408
#I  ReadTest is no longer supported. Please use more robust and flexible
#I  Test. For backwards compatibility, ReadTest(<filename>) is replaced
#I  by Test( <filename>, rec( compareFunction := "uptowhitespace" ))
fr:chapter 4
GAP4stones: 997804
#I  ReadTest is no longer supported. Please use more robust and flexible
#I  Test. For backwards compatibility, ReadTest(<filename>) is replaced
#I  by Test( <filename>, rec( compareFunction := "uptowhitespace" ))
########> Diff in /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\
GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\
ble-snapshot/pkg/FR-2.4.1/tst/chapter-5-a.tst, line 1276:
# Input is:
a := mealyel[1][1][2];
# Expected output:
<Mealy element on alphabet [ 1 .. 2 ] with 2 states>
# But found:
<Mealy element on alphabet [ 1, 2 ] with 2 states>
########
fr:chapter 5 (1/2)
GAP4stones: 637755
#I  ReadTest is no longer supported. Please use more robust and flexible
#I  Test. For backwards compatibility, ReadTest(<filename>) is replaced
#I  by Test( <filename>, rec( compareFunction := "uptowhitespace" ))
########> Diff in /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\
GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\
ble-snapshot/pkg/FR-2.4.1/tst/chapter-5-b.tst, line 111:
# Input is:
AlphabetInvolution(GammaPQMachine(3,5));
# Expected output:
[ 6, 5, 4, 3, 2, 1 ]
# But found:
#I  MakeReadWriteGlobal: QUATERNIONBASIS@fr already read-write
Error, Variable: 'QUATERNIONBASIS@FR' is read only
########
########> Diff in /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\
GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\
ble-snapshot/pkg/FR-2.4.1/tst/chapter-5-b.tst, line 113:
# Input is:
AlphabetInvolution(GammaPQMachine(5,7));
# Expected output:
[ 8, 7, 6, 5, 4, 3, 2, 1 ]
# But found:
#I  MakeReadWriteGlobal: QUATERNIONBASIS@fr already read-write
Error, Variable: 'QUATERNIONBASIS@FR' is read only
########
########> Diff in /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\
GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\
ble-snapshot/pkg/FR-2.4.1/tst/chapter-5-b.tst, line 380:
# Input is:
perm := Random(SymmetricGroup(5));
# Expected output:
(2,4,3)
# But found:
(1,2,5,4,3)
########
fr:chapter 5 (2/2)
GAP4stones: 520833
#I  RunPackageTests("fr", "2.4.1", "tst/testall.g", auto): runtime 15177
============================OUTPUT END================================
laurentbartholdi commented 7 years ago

Thanks!

This unearthed a bug in GAP in that it sometimes modifies an argument secretly, see Issue https://github.com/gap-system/gap/issues/1179 which I just filed.

On Tue, 7 Mar 2017 at 11:21 Alexander Konovalov notifications@github.com wrote:

The following happens while testing the package with the GAP stable-4.8 branch:

============================OUTPUT START==============================

I RunPackageTests("fr", "2.4.1", "tst/testall.g", auto);

��������������������������� GAP unknown of 2017-03-06 13:07:58 (GMT) ��� GAP ��� https://www.gap-system.org ��������������������������� Architecture: x86_64-pc-linux-gnu-gcc-default64 Libs used: gmp, readline Loaded workspace: wsp.g Components: trans 1.0, prim 2.1, small 1.0, id 1.0 Packages: ACE 5.2, AClib 1.2, Alnuth 3.0.0, AtlasRep 1.5.1, AutPGrp 1.8, Browse 1.8.6, CRISP 1.4.4, Cryst 4.1.12, CrystCat 1.1.6, CTblLib 1.2.2, FactInt 1.5.4, FGA 1.3.1, FR 2.4.1, GAPDoc 1.5.1, GBNP 1.0.3, IO 4.4.6, IRREDSOL 1.3.1, LAGUNA 3.7.0, lpres 0.4.1, nq 2.5.3, Polenta 1.3.7, Polycyclic 2.11, RadiRoot 2.7, ResClasses 4.6.0, Sophus 1.23, SpinSym 1.5, TomLib 1.2.6, Utils 0.46 Try '??help' for help. See also '?copyright', '?cite' and '?authors'

I ReadTest is no longer supported. Please use more robust and flexible

I Test. For backwards compatibility, ReadTest() is replaced

I by Test( , rec( compareFunction := "uptowhitespace" ))

fr:chapter 12 GAP4stones: 300000000

I ReadTest is no longer supported. Please use more robust and flexible

I Test. For backwards compatibility, ReadTest() is replaced

I by Test( , rec( compareFunction := "uptowhitespace" ))

fr:chapter 3 GAP4stones: 1020408

I ReadTest is no longer supported. Please use more robust and flexible

I Test. For backwards compatibility, ReadTest() is replaced

I by Test( , rec( compareFunction := "uptowhitespace" ))

fr:chapter 4 GAP4stones: 997804

I ReadTest is no longer supported. Please use more robust and flexible

I Test. For backwards compatibility, ReadTest() is replaced

I by Test( , rec( compareFunction := "uptowhitespace" ))

########> Diff in /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\ GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\ ble-snapshot/pkg/FR-2.4.1/tst/chapter-5-a.tst, line 1276:

Input is:

a := mealyel[1][1][2];

Expected output:

<Mealy element on alphabet [ 1 .. 2 ] with 2 states>

But found:

<Mealy element on alphabet [ 1, 2 ] with 2 states> ######## fr:chapter 5 (1/2) GAP4stones: 637755

I ReadTest is no longer supported. Please use more robust and flexible

I Test. For backwards compatibility, ReadTest() is replaced

I by Test( , rec( compareFunction := "uptowhitespace" ))

########> Diff in /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\ GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\ ble-snapshot/pkg/FR-2.4.1/tst/chapter-5-b.tst, line 111:

Input is:

AlphabetInvolution(GammaPQMachine(3,5));

Expected output:

[ 6, 5, 4, 3, 2, 1 ]

But found:

I MakeReadWriteGlobal: QUATERNIONBASIS@fr already read-write

Error, Variable: 'QUATERNIONBASIS@FR' is read only ######## ########> Diff in /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\ GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\ ble-snapshot/pkg/FR-2.4.1/tst/chapter-5-b.tst, line 113:

Input is:

AlphabetInvolution(GammaPQMachine(5,7));

Expected output:

[ 8, 7, 6, 5, 4, 3, 2, 1 ]

But found:

I MakeReadWriteGlobal: QUATERNIONBASIS@fr already read-write

Error, Variable: 'QUATERNIONBASIS@FR' is read only ######## ########> Diff in /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\ GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\ ble-snapshot/pkg/FR-2.4.1/tst/chapter-5-b.tst, line 380:

Input is:

perm := Random(SymmetricGroup(5));

Expected output:

(2,4,3)

But found:

(1,2,5,4,3) ######## fr:chapter 5 (2/2) GAP4stones: 520833

I RunPackageTests("fr", "2.4.1", "tst/testall.g", auto): runtime 15177

============================OUTPUT END================================

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gap-packages/fr/issues/19, or mute the thread https://github.com/notifications/unsubscribe-auth/ACIIUBEYPY8qyxu4sFGHCamNG9LKgAKvks5rjS_CgaJpZM4MVSrg .

-- Laurent Bartholdi DMA, École Normale Supérieure, 45 rue d'Ulm, 75005 Paris. +33 14432 2060 Mathematisches Institut, Universität Göttingen, Bunsenstrasse 3-5, D-37073 Göttingen. +49 551 39 7826

olexandr-konovalov commented 7 years ago

@laurentbartholdi I still redistribute GAP with FR 2.4.1. Will there be a new release with tests fixed soon?

laurentbartholdi commented 7 years ago

Dear Alex: I just uploaded 2.4.2 (thanks to some changes kindly PR'd by Max).

On Wed, Aug 23, 2017 at 11:27 AM, Alexander Konovalov < notifications@github.com> wrote:

@laurentbartholdi https://github.com/laurentbartholdi I still redistribute GAP with FR 2.4.1. Will there be a new release with tests fixed soon?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gap-packages/fr/issues/19#issuecomment-324274014, or mute the thread https://github.com/notifications/unsubscribe-auth/ACIIUDiZqcy915i0BOEpu9FYk12H0AG0ks5sa_BrgaJpZM4MVSrg .

-- Laurent Bartholdi laurent.bartholdigmailcom École Normale Supérieure: Téléphone +33 1 44322060 Bureau T5, Toits du DMA, 45 Rue d'Ulm, 75005 Paris G.-A. Universität zu Göttingen: Phone: +49 551 39 7826 Office 202, Mathematisches Institut, Bunsenstrasse 3-5, D-37073 Göttingen.

olexandr-konovalov commented 7 years ago

@laurentbartholdi thanks but http://gap-packages.github.io/fr/ still serves version 2.4.1

laurentbartholdi commented 7 years ago

Sorry, it's done now.

On Wed, Aug 23, 2017 at 4:43 PM, Alexander Konovalov < notifications@github.com> wrote:

@laurentbartholdi https://github.com/laurentbartholdi thanks but http://gap-packages.github.io/fr/ still serves version 2.4.1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gap-packages/fr/issues/19#issuecomment-324357844, or mute the thread https://github.com/notifications/unsubscribe-auth/ACIIUBYjPIL7HtndkzcX5haLviK5xUVeks5sbDqtgaJpZM4MVSrg .

-- Laurent Bartholdi laurent.bartholdigmailcom École Normale Supérieure: Téléphone +33 1 44322060 Bureau T5, Toits du DMA, 45 Rue d'Ulm, 75005 Paris G.-A. Universität zu Göttingen: Phone: +49 551 39 7826 Office 202, Mathematisches Institut, Bunsenstrasse 3-5, D-37073 Göttingen.

olexandr-konovalov commented 7 years ago

Thanks - success this time!

* FR - new version 2.4.2 discovered!!!
  ============================================
  Getting new archives from 
  https://github.com/gap-packages/fr/releases/download/v2.4.2/fr-2.4.2
[ ".tar.gz" ]
  unpacking fr-2.4.2.tar.gz
  Validation of the info file successful!
  Package FR 2.4.2 from 23/08/2017 has dependencies:
  * NeededOtherPackages [ [ "FGA", ">=1.1" ], [ "Polycyclic", ">=2.2" ], 
  [ "GAPDoc", ">=1.0" ] ]
  * GAP >=4.8
  * SuggestedOtherPackages [ [ "GBNP", ">=0.9" ], [ "NQ", ">=2.4" ], 
  [ "LPRES", ">=0.1" ] ]
  finding text files  . . .

=====================text files==========================
fr-2.4.2/CHANGES
fr-2.4.2/COPYING
fr-2.4.2/init.g
fr-2.4.2/makedoc.g
fr-2.4.2/PackageInfo.g
fr-2.4.2/read.g
fr-2.4.2/README
fr-2.4.2/TODO
fr-2.4.2/doc/chap0.html
fr-2.4.2/doc/chap0.txt
fr-2.4.2/doc/chap1.html
fr-2.4.2/doc/chap1.txt
fr-2.4.2/doc/chap10.html
fr-2.4.2/doc/chap10.txt
fr-2.4.2/doc/chap11.html
fr-2.4.2/doc/chap11.txt
fr-2.4.2/doc/chap2.html
fr-2.4.2/doc/chap2.txt
fr-2.4.2/doc/chap3.html
fr-2.4.2/doc/chap3.txt
fr-2.4.2/doc/chap4.html
fr-2.4.2/doc/chap4.txt
fr-2.4.2/doc/chap5.html
fr-2.4.2/doc/chap5.txt
fr-2.4.2/doc/chap6.html
fr-2.4.2/doc/chap6.txt
fr-2.4.2/doc/chap7.html
fr-2.4.2/doc/chap7.txt
fr-2.4.2/doc/chap8.html
fr-2.4.2/doc/chap8.txt
fr-2.4.2/doc/chap9.html
fr-2.4.2/doc/chap9.txt
fr-2.4.2/doc/chapBib.html
fr-2.4.2/doc/chapBib.txt
fr-2.4.2/doc/chapInd.html
fr-2.4.2/doc/chapInd.txt
fr-2.4.2/doc/chooser.html
fr-2.4.2/doc/fr.xml
fr-2.4.2/doc/frbib.xml
fr-2.4.2/doc/frbib.xml.bib
fr-2.4.2/doc/index.html
fr-2.4.2/doc/lefttoc.css
fr-2.4.2/doc/manual.css
fr-2.4.2/doc/nocolorprompt.css
fr-2.4.2/doc/ragged.css
fr-2.4.2/doc/times.css
fr-2.4.2/doc/toggless.css
fr-2.4.2/gap/algebra.gd
fr-2.4.2/gap/algebra.gi
fr-2.4.2/gap/bisets.gd
fr-2.4.2/gap/bisets.gi
fr-2.4.2/gap/cp.gd
fr-2.4.2/gap/cp.gi
fr-2.4.2/gap/examples.gd
fr-2.4.2/gap/examples.gi
fr-2.4.2/gap/frelement.gd
fr-2.4.2/gap/frelement.gi
fr-2.4.2/gap/frmachine.gd
fr-2.4.2/gap/frmachine.gi
fr-2.4.2/gap/group.gd
fr-2.4.2/gap/group.gi
fr-2.4.2/gap/helpers.gd
fr-2.4.2/gap/helpers.gi
fr-2.4.2/gap/linear-gbnp.gi
fr-2.4.2/gap/linear.gi
fr-2.4.2/gap/mealy.gd
fr-2.4.2/gap/mealy.gi
fr-2.4.2/gap/perlist.gd
fr-2.4.2/gap/perlist.gi
fr-2.4.2/gap/pickle.g
fr-2.4.2/gap/vector.gd
fr-2.4.2/gap/vector.gi
fr-2.4.2/gap/vhgroup.gi
fr-2.4.2/guest/Brieussels_algorithm.g
fr-2.4.2/tst/chapter-12.tst
fr-2.4.2/tst/chapter-3.tst
fr-2.4.2/tst/chapter-4.tst
fr-2.4.2/tst/chapter-5-a.tst
fr-2.4.2/tst/chapter-5-b.tst
fr-2.4.2/tst/cp.tst
fr-2.4.2/tst/frelements.g
fr-2.4.2/tst/frmachines.g
fr-2.4.2/tst/groups.g
fr-2.4.2/tst/kneading.g
fr-2.4.2/tst/mealyelements.g
fr-2.4.2/tst/mealymachines.g
fr-2.4.2/tst/testall.g

=====================end of the list of text files=======
=====================binary files========================
fr-2.4.2/BUGS
fr-2.4.2/doc/basilica-ball.jpg
fr-2.4.2/doc/basilica-nucleus.jpg
fr-2.4.2/doc/fornaess-sibony.jpg
fr-2.4.2/doc/hasse.jpg
fr-2.4.2/doc/manual.js
fr-2.4.2/doc/manual.pdf
fr-2.4.2/doc/manual.six
fr-2.4.2/doc/rainbow.js
fr-2.4.2/doc/toggless.js

=====================end of the list of binary files=====
=====================ignored files=======================

=====================end of the list of ignored files====