gap-packages / grape

GRaph Algorithms using PErmutation groups

https://gap-packages.github.io/grape/

5 stars 7 forks source link

Improve Windows support, run Windows CI tests on AppVeyor #12

Closed fingolfin closed 5 years ago

fingolfin commented 5 years ago

The benefits of testing regularly on Windows should be obvious :-).

Contains PRs #11 and #13. Also contains a commit which adds a new helper function GAP_Exec, and one that avoids some temporary files. All these additional changes were needed to make it work in the Windows virtual machines provided by AppVeyor. I think that means it will also help regular users.

Closes #11 Closes #13

codecov[bot] commented 5 years ago

Codecov Report

Merging #12 into master will decrease coverage by 0.29%. The diff coverage is 55.26%.

@@            Coverage Diff            @@
##           master      #12     +/-   ##
=========================================
- Coverage   60.29%   59.99%   -0.3%     
=========================================
  Files           9        9             
  Lines        6437     6532     +95     
=========================================
+ Hits         3881     3919     +38     
- Misses       2556     2613     +57

Impacted Files	Coverage Δ
lib/grape.g	`77.01% <55.26%> (-0.08%)`	:arrow_down:
nauty22/nauty.c	`65% <0%> (-0.07%)`	:arrow_down:
nauty22/naututil.c	`23.5% <0%> (+0.05%)`	:arrow_up:
nauty22/dreadnaut.c	`30.83% <0%> (+0.22%)`	:arrow_up:

fingolfin commented 5 years ago

Using this, I could at least confirm that PR #11 should indeed resolve #10 resp. resolve https://github.com/gap-system/gap/issues/1523 (@lhsoicher OK to merge PR #11?)

However, the Windows tests on AppVeyor still both fail, with the following message printed a dozen times or so: The system cannot find the path specified. This seems to be a message by Windows resp. cmd.exe I have not yet analyzed this further. This also required one other minor change which I'll submit as separate PR now, so that it can be merged already.