gap-packages / grape

GRaph Algorithms using PErmutation groups

https://gap-packages.github.io/grape/

5 stars 7 forks source link

Add License field to PackageInfo.g, rename license file #29

Closed fingolfin closed 1 year ago

fingolfin commented 3 years ago

Also update reference URL to use http sand point at GPL 2.0

This is not urgent at all, just would be nice to have in some future release.

codecov[bot] commented 3 years ago

Codecov Report

Merging #29 (53eda5e) into master (c1ae51c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   79.90%   79.90%           
=======================================
  Files           2        2           
  Lines        3882     3882           
=======================================
  Hits         3102     3102           
  Misses        780      780

lhsoicher commented 3 years ago

Thanks @fingolfin @alex-konovalov. I am concerned to suggest an overall license for GRAPE in the PackageInfo.g file and in having a file called LICENSE in the GRAPE home directory, due to the included nauty 2.2 package having its its own (different) license, as made clear in the README and GRAPE package manual.

fingolfin commented 1 year ago

Now that the new nauty is in, we can make progress on this resp. open a new PR: the new nauty seems to be licensed under Apache License, Version 2.0. The existing grape code is GPL 2 or later.

Unfortunately Apache is not compatible with GPL 2, but it is compatible with GPL 3. So a suitable License field in PackageInfo.g would look like this:

##  Machine readable license information (as an SPDX identifier)
License := "Apache-2.0 AND GPL-2.0-or-later"

However, also the text in README.md and doc/grape.tex should be adapted to clearly state the license of the nauty portion. I can submit a PR for this later

fingolfin commented 1 year ago

@lhsoicher this PR is ready for merging now