gap-packages / grape

GRaph Algorithms using PErmutation groups
https://gap-packages.github.io/grape/
5 stars 7 forks source link

Update CI integration, switch Cygwin tests to GH Actions #36

Closed fingolfin closed 1 year ago

fingolfin commented 1 year ago

Please DO NOT MERGE until I've verified it all works as expected

lhsoicher commented 1 year ago

@fingolfin Please let me know if/when I can merge this PR. Thanks.

fingolfin commented 1 year ago

Strange, it dies with error

+ ./configure /home/runneradmin/gap
./configure: line 4: /home/runneradmin/gap/sysinfo.gap

inside of gap-actions/build-pkg@cygwin-v1; yet in the preceding gap-actions/setup-gap@cygwin-v2 that file existed and seemingly worked fine:

  ==== Checking profiling
  Running './configure' '/home/runneradmin/gap' 
  Using settings from /home/runneradmin/gap/sysinfo.gap
  Running 'gmake' 'clean' 
  rm -rf bin/x86_64-pc-cygwin-default64-kv8 gen
  Running './configure' '/home/runneradmin/gap' 
  Using settings from /home/runneradmin/gap/sysinfo.gap
  Running 'gmake' 
     GAC     src/profiling.cc => gen/src/profiling.o
     GAC     src/md5.cc => gen/src/md5.o
     GAC     gen/src/profiling.o => bin/x86_64-pc-cygwin-default64-kv8/profiling.so

@ChrisJefferson @wilfwilson any idea what might be causing this?

wilfwilson commented 1 year ago

I'm really not sure @fingolfin, sorry.

fingolfin commented 1 year ago

This is really strange, considering that I copied the CI setup basically verbatim from datastructures and io, where it works smoothly.

Perhaps this requires using tmate to log into the GH action CI job and investigate more closely. I'll try and see if I can do that (if nobody beats me to it) later today, but now I need to prepare for my lecture

ChrisJefferson commented 1 year ago

I will have a quick look now

ChrisJefferson commented 1 year ago

One issue is you've changed the configure script to use source instead of ., but the script is hard-wired to /bin/sh, which doesn't (have to) support source if it isn't actually bash.

fingolfin commented 1 year ago

Problem was caused by linenedings. Chris fixed it by adding a .gitatributes file.