search

gap-packages / guava

GAP package guava - computations relative to error-correcting codes
https://gap-packages.github.io/guava
Other
13 stars 7 forks source link

src/wtdist.c:177: bad test #24

Closed dcb314 closed 7 years ago

dcb314 commented 8 years ago

src/wtdist.c:177]: (warning) Logical conjunction always evaluates to false: EXPR < 1 && EXPR > 3.

Source code is

if ( argc - optionCountPlus1 < 1 && argc - optionCountPlus1 > 3 ) {

Suggest new code

if ( argc - optionCountPlus1 < 1 || argc - optionCountPlus1 > 3 ) {

osj1961 commented 7 years ago

Fixed with commit 45698f22985dec282f953dbb5bae85c4068e0981 Thanks!