gap-packages / guava

GAP package guava - computations relative to error-correcting codes
https://gap-packages.github.io/guava
Other
13 stars 7 forks source link

Guava build fails on Mac #54

Closed olexandr-konovalov closed 2 years ago

olexandr-konovalov commented 3 years ago

For version 3.15 I have

cc  -O2 -c   ./src/generate.c 
./src/generate.c:425:10: error: implicit declaration of function 'RmvRSG' is
      invalid in C99 [-Werror,-Wimplicit-function-declaration]
         removeRedunSGens( G, 1);
         ^
./src/extname.h:224:37: note: expanded from macro 'removeRedunSGens'
#define removeRedunSGens            RmvRSG
                                    ^
./src/generate.c:437:7: error: implicit declaration of function 'InfGrp' is
      invalid in C99 [-Werror,-Wimplicit-function-declaration]
      informGroup(G);
      ^
./src/extname.h:113:37: note: expanded from macro 'informGroup'
#define informGroup                 InfGrp
                                    ^
2 errors generated.
make[1]: *** [generate.o] Error 1
make: *** [desauto] Error 2

This is what gcc --version says:

Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/c++/4.2.1
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
fingolfin commented 2 years ago

It does build fine for me on a mac, though...

olexandr-konovalov commented 2 years ago

Still have same problem with Apple clang version 13.0.0 (clang-1300.0.29.30)

fingolfin commented 2 years ago

This was fixed in d8487f95f311305029be644c8a8260ae796e7bc2 but apparently never put into a release sigh.

fingolfin commented 2 years ago

Resolved in v3.16