search

gap-packages / guava

GAP package guava - computations relative to error-correcting codes
https://gap-packages.github.io/guava
Other
13 stars 7 forks source link

Make a new release #60

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

... with the changes that accumulated (at least one bug fix, and the new License field).

fingolfin commented 2 years ago

@osj1961 can you look into this? Leon's code doesn't build on recent macOS anymore, it needs a fix which is already in this git repository but never reached end users.

Before doing a release, please consider merging the open PRs.

Finally, I could also take care of all this for you, it should require less than 5 minutes total.

osj1961 commented 2 years ago

Hi Max, I'll work on it this weekend. Best, Joe

Joseph E. Fields Professor of Mathematics Southern Connecticut State University http://www.southernct.edu/~fields/

From: Max Horn @.> Sent: Tuesday, March 29, 2022 8:23 PM To: gap-packages/guava @.> Cc: Fields, Joseph @.>; Mention @.> Subject: Re: [gap-packages/guava] Make a new release (Issue #60)

@osj1961https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fosj1961&data=04%7C01%7Cfieldsj1%40southernct.edu%7Cbce1d832ce944669d1eb08da11e379b5%7C58736863d60e40ce95c60723c7eaaf67%7C0%7C0%7C637841965946284967%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=fPUNvlptYjZRvk3UEBBkHMTB485HvpZnLUd7OlLs5SI%3D&reserved=0 can you look into this? Leon's code doesn't build on recent macOS anymore, it needs a fix which is already in this git repository but never reached end users.

Before doing a release, please consider merging the open PRs.

Finally, I could also take care of all this for you, it should require less than 5 minutes total.

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgap-packages%2Fguava%2Fissues%2F60%23issuecomment-1082491941&data=04%7C01%7Cfieldsj1%40southernct.edu%7Cbce1d832ce944669d1eb08da11e379b5%7C58736863d60e40ce95c60723c7eaaf67%7C0%7C0%7C637841965946284967%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Zw%2FKKsHhortXbDQwpqMCjDv8FdCUsFnRy%2BRWwnyvkE4%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGEKV5U32XS7FWX25EMTJ3VCONG7ANCNFSM5RDFOTXQ&data=04%7C01%7Cfieldsj1%40southernct.edu%7Cbce1d832ce944669d1eb08da11e379b5%7C58736863d60e40ce95c60723c7eaaf67%7C0%7C0%7C637841965946284967%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Yw3P%2FZP6dcxnMdjINEv7EkN0GYqzItwza7n%2BUtRuMug%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

fingolfin commented 2 years ago

Hi @osj1961 do you think everything is ready ? If so, I'd be happy to make the release for you, if you like

fingolfin commented 2 years ago

@osj1961 any news on this?

osj1961 commented 2 years ago

Okay, so I was able to put some time in on guava this weekend. I tried using the latest version of the ReleaseTools script, which seems to fail prior to pushing anything to github. I don't know what the "autoheader" it is complaining about is...

fields@elemenopi:~/Desktop/guava$ ../ReleaseTools/release-gap-package Using PYTHON = 'python3' Extracting information from PackageInfo.g... Package GUAVA 3.16 Building GAP package documentation (using makedoc.g) Using archive basename guava-3.16 Using GitHub repository gap-packages/guava Using GitHub username gap-packages Using branch master Creating git tag v3.16

Exporting repository content for tag 'v3.16' Building GAP package documentation for archives (using makedoc.g) Removing unnecessary files Generating build system files

osj1961 commented 2 years ago

@fingolfin Max, if you could make the release and perhaps let me know what I'm doing wrong it would be appreciated.

fingolfin commented 2 years ago

autoheader is part of GNU autoconf (I think; maybe it was automake instead). Depending on what OS you are using, you can resolve this by installing automake and autoconf via your package manager.

Anyway, I can take care of the release, sure!

fingolfin commented 2 years ago

I've fixed an issue with the date in PackageInfo.g in 988624d267f0efd2bb7c48f65759af24305e88ba and made the release.

osj1961 commented 2 years ago

Hi Max, Thanks for the offer. I think I'd prefer to try to get it done myself. I'm having an ongoing problem (because releases are relatively infrequent), that by the time I'm ready to do a new one, either the process has changed, or I've forgotten what to do! So, in a nutshell, I need the refresher. On the other hand, if it's time critical on the GAP side - I may need another week - perhaps you should go ahead... Best, Joe

Joseph E. Fields Professor of Mathematics Southern Connecticut State University http://www.southernct.edu/~fields/

From: Max Horn @.> Sent: Saturday, April 9, 2022 5:59 AM To: gap-packages/guava @.> Cc: Fields, Joseph @.>; Mention @.> Subject: Re: [gap-packages/guava] Make a new release (Issue #60)

Hi @osj1961https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fosj1961&data=04%7C01%7Cfieldsj1%40southernct.edu%7C2abb2580b95545fef7e108da1a0f9ad3%7C58736863d60e40ce95c60723c7eaaf67%7C0%7C0%7C637850951581830681%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KTEX%2B65TpKSBxjdNnZ%2FM6eGuHY3XnECE7FwwhQ5Ry4Y%3D&reserved=0 do you think everything is ready ? If so, I'd be happy to make the release for you, if you like

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgap-packages%2Fguava%2Fissues%2F60%23issuecomment-1093843215&data=04%7C01%7Cfieldsj1%40southernct.edu%7C2abb2580b95545fef7e108da1a0f9ad3%7C58736863d60e40ce95c60723c7eaaf67%7C0%7C0%7C637850951581830681%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2FDGXmqKPbPrI6NQ3gUAVfZ5dUPigWINQ04DN6liq1ZU%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGEKVY7MNS5KK2MHSMU623VEFIHFANCNFSM5RDFOTXQ&data=04%7C01%7Cfieldsj1%40southernct.edu%7C2abb2580b95545fef7e108da1a0f9ad3%7C58736863d60e40ce95c60723c7eaaf67%7C0%7C0%7C637850951581830681%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ocqD8m2cGOwaMt%2FDYtmXFDDGLajbF70T3m36bROmQrQ%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

fingolfin commented 2 years ago

Hi @osj1961, actually, the new release discussed on this issue already happened 2022-04-24; and since then we had another 2022-09-05.

(I wonder if a notification email for this only reached you just now? The same time you wrote your comment, several other people suddenly commented on issues and PRs months past the last activity there, making me wonder if they all received "delayed" notification emails on that day (perhaps GitHub discovered a stuck mail queue somewhere?)