gap-packages / guava

GAP package guava - computations relative to error-correcting codes
https://gap-packages.github.io/guava
Other
13 stars 7 forks source link

Fix PutStandardForm *again* #75

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

Commit 8474420b5faf7469e841e6e3674bed0e050db0c6 was meant to "fix" PutStandardForm according to the commit message, although it is not specified what it was supposed to fix.

This led to changed behavior of PutStandardForm. This was meant to be fixed by c2b498f3d1635410c48461e3c8300752764b8c7d but it was incorrect, too, now immediately leading to errors (it tried to use the return value of TriangulizeMat, but this procedure never returns anything)

Let's hope that three is the charm...

Fixes #53 essentially in exactly the way already suggested in a comment there from 2020.

codecov[bot] commented 2 years ago

Codecov Report

Merging #75 (160bfc1) into master (41bf2ca) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   49.36%   49.37%           
=======================================
  Files          44       44           
  Lines       14666    14666           
  Branches      203      203           
=======================================
+ Hits         7240     7241    +1     
+ Misses       7426     7425    -1     
Impacted Files Coverage Δ
lib/matrices.gi 26.03% <0.00%> (ø)
lib/codeman.gi 27.58% <0.00%> (+0.06%) :arrow_up: