gap-packages / guava

GAP package guava - computations relative to error-correcting codes

https://gap-packages.github.io/guava

Other

13 stars 7 forks source link

Fix input/output handling of subprocesses #84

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

don't pass on user input to subprocesses (while in practice none of them should be processing any, there is no point in taking a risk?)
don't print output of subprocesses to the terminal

Resolves #73

An alternative would be to use OutputTextString instead of OutputTextNone to capture output and show it if some InfoLevel is set suitably high. That might be helpful for debugging in some cases?

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (69be126) into master (2e8734b) will not change coverage. The diff coverage is 40.00%.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   49.37%   49.37%           
=======================================
  Files          44       44           
  Lines       14668    14668           
  Branches      203      203           
=======================================
  Hits         7242     7242           
  Misses       7426     7426

Impacted Files	Coverage Δ
lib/codeman.gi	`27.58% <0.00%> (ø)`
lib/codeops.gi	`44.87% <50.00%> (ø)`