search

gap-packages / io

GAP package IO to do input and output
https://gap-packages.github.io/io/
Other
14 stars 14 forks source link

Make profiling work when IO_fork is called #71

Closed ChrisJefferson closed 6 years ago

ChrisJefferson commented 6 years ago

This is the IO part of https://github.com/gap-system/gap/pull/2907

codecov[bot] commented 6 years ago

Codecov Report

Merging #71 into master will increase coverage by 7.7%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #71     +/-   ##
=========================================
+ Coverage   44.54%   52.24%   +7.7%     
=========================================
  Files           1       13     +12     
  Lines        1228     4825   +3597     
=========================================
+ Hits          547     2521   +1974     
- Misses        681     2304   +1623
Impacted Files Coverage Δ
src/io.c 44.67% <100%> (+0.13%) :arrow_up:
gap/pickle.gi 70.45% <0%> (ø)
gap/http.gd 100% <0%> (ø)
gap/background.gd 100% <0%> (ø)
gap/realrandom.gi 42.18% <0%> (ø)
gap/realrandom.gd 100% <0%> (ø)
gap/http.gi 61.09% <0%> (ø)
gap/pickle.gd 100% <0%> (ø)
gap/background.gi 18.56% <0%> (ø)
gap/io.gi 59.24% <0%> (ø)
... and 3 more
ChrisJefferson commented 6 years ago

Now all fixed up. I also added stable-4.10 to .travis.yml to make sure I didn't break it (I didn't).

fingolfin commented 6 years ago

@markuspf was it really necessary to merge this right away, despite my request-for-changes review, without at least giving me another chance to take a look at it? Why the rush?

@ChrisJefferson actually, the package lists GAP 4.9 as its minimal required package, so at the very least, I'd like to test with that. I've now updated the .travis.yml file accordingly. Otherwise, the changes of course were fine now, thanks!