search

gap-packages / io

GAP package IO to do input and output
https://gap-packages.github.io/io/
Other
14 stars 14 forks source link

Rename io.c -> kernel.c #76

Closed ChrisJefferson closed 5 years ago

ChrisJefferson commented 5 years ago

Several code coverage systems seem to confuse src/io.c in GAP with src/io.c in the IO package, so rename io.c in the IO package.

While this does seem a bit of an excessive fix, on the other hand it should be (hopefully!) the easiest way to improve coverage measurement.

fingolfin commented 5 years ago

I am not convinced that the io.c from this package is the problem with the GAP coverage. The "bad" coverage reported by Codecov reports lines as code which are code neither in GAP's nor in IO's io.c.

markuspf commented 5 years ago

Some of the mess was made by io.c in external software such as gmp, which we don't control.

fingolfin commented 5 years ago

We don't need this change, things work fine now thanks to the proper fix by @markuspf