Closed ssiccha closed 3 years ago
I'm still trying to get the 32bit tests to pass.
@fingolfin The ABI=32
run is failing: https://github.com/ssiccha/io/runs/1412602919?check_suite_focus=true#step:3:1013
I've compared the run with a successful one from travis. The line that fails in the action looks like this on travis:
/bin/bash /home/travis/gap/libtool --mode=compile gcc -m32 -g -O2 -MQ gen/src/io.lo -MMD -MP -MF gen/src/io.d -Igen --coverage -m32 -o gen/src/io.lo -I/home/travis/gap/build -I/home/travis/gap/src -I/home/travis/gap -DHAVE_CONFIG_H -c src/io.c
https://travis-ci.com/github/gap-packages/io/jobs/392772295#L1167 and like this in the action run:
/bin/bash /home/runner/gap/libtool --mode=compile gcc -g -O2 -MQ gen/src/io.lo -MMD -MP -MF gen/src/io.d -Igen --coverage -m32 -o gen/src/io.lo -I/home/runner/gap/build -I/home/runner/gap/src -I/home/runner/gap -DHAVE_CONFIG_H -c src/io.c
https://github.com/ssiccha/io/runs/1412602919?check_suite_focus=true#step:3:1013
So it seems there is an -m32
missing directly after the compile gcc
bit. Do you have any idea what the reason could be for this?
32 bit tests work now.
@ssiccha do you plan to finish this or should I take over? I also don't quite understand how this relates to PR #89 resp. vice versa...
What happened to this and similar PRs elsewhere? Is there a canonical setup others may use? It would be useful to have a canonical setup in the example package https://github.com/gap-packages/example/pulls ...
@alex-konovalov Re the other PRs: I didn't have the time to finish them. :/
Re the example package: I think that's a good idea. @fingolfin Would it make sense to extend PackageMaker
so that PackageWizard
also offers to create a GitHub action for CI testing?
Tests work. See https://github.com/ssiccha/io/actions
Updated the Codecov badge and squashed.
@fingolfin Could you have a look again?
This PR configures GitHub Actions to run the package tests. It was created by a script. You can view the results of the added GitHub action at: https://github.com/ssiccha/io/actions This PR contains four commits which do:
.github/workflows/CI.yml
which configures GitHub Actions to run the package tests,.travis.yml
file if it exists in the package,Since this PR is generated automatically, please double-check that the last three commits do not break anything. You may also have to specify values for the variables
GAP_PKGS_TO_BUILD
andGAP_PKGS_TO_CLONE
in the.github/workflows/CI.yml
file as described further below.The added GitHub action
CI
contains a jobtest
, which runs your package's tests using the same scripts as previously did Travis, namely those from https://github.com/gap-system/pkg-ci-scripts By default it tests your package with the following gap branches:The action
CI
also contains a jobmanual
, which compiles your package's documentation with latex and uploads the resulting pdf as an artifact, which means that it can be downloaded once all jobs of the action completed.If you need to compile packages to load your package, set the input
GAP_PKGS_TO_BUILD
for the actiongap-actions/setup-gap-for-packages@v1
to a space-separated list of packages as follows:If you need to clone the development version of packages set the input
GAP_PKGS_TO_CLONE
for the actiongap-actions/setup-gap-for-packages@v1
to a space-separated list of packages as follows:Notice that you may also have to set inputs for the action
gap-actions/setup-gap-for-packages@v1
in the jobmanual
.If you want to adjust which tests are run have a look at the documentation of the job matrix.You can add changes to this PR by adding my fork as a remote, checking it out and then committing and pushing as follows:
The custom gap actions which are used by the added action can be found at: https://github.com/gap-actions