gap-packages / io

GAP package IO to do input and output
https://gap-packages.github.io/io/
Other
14 stars 14 forks source link

Can't unpickle matrix groups with no generators #92

Open ChrisJefferson opened 3 years ago

ChrisJefferson commented 3 years ago

In GAP, we can make groups with no generators, so calling Group(GeneratorsOfGroup(g)) doesn't work. The fix is to pass the identity of g as the second argument of 'Group'.

I've fixed this for permutation groups, but not for matrix groups, as nothing simple seems able to fix It:

We could just make a fresh matrix group where "GeneratorsOfGroup" won't return nothing, or change how we pickle them so we always pass the identity in (changing the name of course).