search

gap-packages / io

GAP package IO to do input and output
https://gap-packages.github.io/io/
Other
14 stars 14 forks source link

configure.ac: update for autoconf >=2.70 #98

Closed fingolfin closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #98 (b9616f9) into master (eb60509) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head b9616f9 differs from pull request most recent head 8162681. Consider uploading reports for the commit 8162681 to get more accurate results

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   61.19%   61.19%           
=======================================
  Files          15       15           
  Lines        4888     4889    +1     
=======================================
+ Hits         2991     2992    +1     
  Misses       1897     1897
Impacted Files Coverage Δ
src/io.c 68.67% <0.00%> (+0.02%) :arrow_up:
fingolfin commented 3 years ago

@ChrisJefferson @wilfwilson just FYI, this should fix the io issue with autoconf >= 2.70 while retaining full support for 2.69.

fingolfin commented 3 years ago

OK, it seems there is one more issue: autoconf 2.70 seems to require config.guess and config.sub being present. Which is somewhat bonkers, because they should not be needed if one does not use any of the `ACCANONICAL* macros.

Indeed, the manual explicitly used to say that you need those files if you use one of those macros. In 2.70, they removed that language. I need to think about this some more.