gap-packages / polycyclic

Computation with polycyclic groups
https://gap-packages.github.io/polycyclic/
Other
4 stars 9 forks source link

changed `AbelianPcpGroup`, `DihedralPcpGroup` #81

Closed ThomasBreuer closed 1 year ago

ThomasBreuer commented 1 year ago

Now they call the methods for AbelianGroupCons and DihedralGroupCons, respectively, which belong to the package. This way, the AbelianGroup fix from #79 works also for AbelianPcpGroup, and now DihedralPcpGroup(2) works.

codecov[bot] commented 1 year ago

Codecov Report

Merging #81 (b401b38) into master (ca986fc) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   56.27%   56.29%   +0.02%     
==========================================
  Files          87       87              
  Lines       13030    13015      -15     
==========================================
- Hits         7332     7327       -5     
+ Misses       5698     5688      -10     
Impacted Files Coverage Δ
gap/exam/generic.gi 82.60% <100.00%> (-0.40%) :arrow_down:

... and 1 file with indirect coverage changes

fingolfin commented 1 year ago

Does this also resolve issue #80, i.e. AbelianPcpGroup(1,[1]); works now? If so perhaps this could be added as another test case?

ThomasBreuer commented 1 year ago

Does this also resolve issue #80, i.e. AbelianPcpGroup(1,[1]); works now? If so perhaps this could be added as another test case?

Yes, of course. Thanks for the hint.