Closed ThomasBreuer closed 1 year ago
Merging #81 (b401b38) into master (ca986fc) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 56.27% 56.29% +0.02%
==========================================
Files 87 87
Lines 13030 13015 -15
==========================================
- Hits 7332 7327 -5
+ Misses 5698 5688 -10
Impacted Files | Coverage Δ | |
---|---|---|
gap/exam/generic.gi | 82.60% <100.00%> (-0.40%) |
:arrow_down: |
Does this also resolve issue #80, i.e. AbelianPcpGroup(1,[1]);
works now? If so perhaps this could be added as another test case?
Does this also resolve issue #80, i.e.
AbelianPcpGroup(1,[1]);
works now? If so perhaps this could be added as another test case?
Yes, of course. Thanks for the hint.
Now they call the methods for
AbelianGroupCons
andDihedralGroupCons
, respectively, which belong to the package. This way, theAbelianGroup
fix from #79 works also forAbelianPcpGroup
, and nowDihedralPcpGroup(2)
works.