search

gap-packages / polycyclic

Computation with polycyclic groups
https://gap-packages.github.io/polycyclic/
Other
4 stars 9 forks source link

Tests fail with GAP 4.13.0 #89

Open orlitzky opened 4 months ago

orlitzky commented 4 months ago

Getting ready to ship the new GAP and I noticed the test failure below. If my memory is correct, I tested polycyclic with the release candidates and the failure had not appeared yet.

testing: /var/lib/portage/tmp/portage/dev-gap/polycyclic-2.16/temp/pkg/polycyclic-2.16/tst/bugfix.tst
########> Diff in /var/lib/portage/tmp/portage/dev-gap/polycyclic-2.16/temp/pkg/polycyclic-2.16/tst/bugfix.tst:58
# Input is:
Igs(G);
# Expected output:
[ g1, g2*g5, g3*g4*g5^2, g4*g5, g5 ]
# But found:
[ g1, g2, g3, g4, g5 ]
########
    6109 ms (164 ms GC) and 307MB allocated for bugfix.tst
fingolfin commented 1 month ago

There are unfortunately various issues with polycyclic at this point, esp. the Igs code. We have a pretty good idea what they are, too, but time to resolve them has been lacking. I plan to work on them once the teaching period is over, and work with my student to completely replace the Igs code and then make a new release. Fingers crossed.