gap-packages / primgrp

GAP Primitive Groups Library

https://gap-packages.github.io/primgrp/

GNU General Public License v2.0

2 stars 5 forks source link

Rename PrimitiveGroup(960,7) from OPlus(8, 2) to O+(8, 2) #33

Closed fingolfin closed 4 years ago

fingolfin commented 4 years ago

This is consistent with all other groups related to O+ or O-

codecov[bot] commented 4 years ago

Codecov Report

Merging #33 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   99.91%   99.92%           
=======================================
  Files          46       46           
  Lines      382936   382936           
=======================================
+ Hits       382624   382631    +7     
+ Misses        312      305    -7

Impacted Files	Coverage Δ
data/gps9.g	`100.00% <100.00%> (ø)`
lib/primitiv.gi	`55.06% <0.00%> (+1.54%)`	:arrow_up:

olexandr-konovalov commented 4 years ago

@fingolfin sorry, haven't seen this while merging #32. Please rebase to resolve merge conflicts.

fingolfin commented 4 years ago

Rebased

olexandr-konovalov commented 4 years ago

Merged that, but should be added to the changelog too.