Closed fchapoton closed 1 year ago
Merging #83 (0bc86bd) into master (a3badbe) will decrease coverage by
1.60%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 60.72% 59.11% -1.61%
==========================================
Files 74 74
Lines 22513 21857 -656
==========================================
- Hits 13670 12921 -749
- Misses 8843 8936 +93
Impacted Files | Coverage Δ | |
---|---|---|
lib/moduleARtheory.gi | 68.96% <ø> (-0.70%) |
:arrow_down: |
lib/modulehomalg.gi | 68.12% <ø> (-1.34%) |
:arrow_down: |
lib/modulespecial.gd | 100.00% <ø> (ø) |
|
lib/pathalgreptype.gi | 27.08% <ø> (-1.79%) |
:arrow_down: |
lib/projpathalgmodule.gi | 64.87% <ø> (-1.55%) |
:arrow_down: |
lib/qpaposet.gi | 30.50% <0.00%> (-6.00%) |
:arrow_down: |
lib/algebra.gi | 28.54% <0.00%> (-4.51%) |
:arrow_down: |
lib/complex.gi | 38.55% <0.00%> (-4.39%) |
:arrow_down: |
lib/derivedcat.gi | 11.59% <0.00%> (-4.35%) |
:arrow_down: |
lib/inflist.gi | 65.73% <0.00%> (-3.21%) |
:arrow_down: |
... and 32 more |
Thank you very much for making all these corrections in the repository. I agree with all of them except the ones involving "irreductible" homomorphisms. It was not correct what was there, but Auslander-Reiten called these homomorphisms "irreducible", which is what I should have used in the first place and, which I think that we should use now. If you agree, could you please change it to "irreducible" homomorphisms? If so, l will immediately merge the pull request.
indeed, done
Thank you very much again!
mainly about "projective, injective, irreducible"