gap-packages / qpa

GAP package for quivers and path algebras
https://folk.ntnu.no/oyvinso/QPA/
GNU General Public License v2.0
30 stars 13 forks source link

Fix some bugs related to isolated vertices #85

Closed jonwanundsen closed 1 year ago

jonwanundsen commented 1 year ago

The function RightModuleOverPathAlgebra(A, mats) assigns a zero-dimensional vector space to all isolated vertices, i.e. vertices that are not the source or target of any arrow. This causes bugs when some of QPA's methods are applied to quivers with isolated vertices: in some cases an incorrect result is returned, while in other cases an error occurs. This patch fixes most of these bugs (that I am aware of, at least) by using the function RightModuleOverPathAlgebra(A, dim_vector, gens) instead.

In addition to the methods I've updated, there are some methods using the function RightModuleOverPathAlgebra(A, mats) that I have not modified, namely the following:

It might be relevant to update the last two of these methods at some point, but I've left them as they are for now.

sunnyquiver commented 1 year ago

Thank you very much for addressing this problem.