gap-packages / recog

The GAP package recog to collect methods for constructive recognition
https://gap-packages.github.io/recog/
GNU General Public License v3.0
6 stars 14 forks source link

Merge documentation of CallMethods #249

Closed ssiccha closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #249 (4dd2828) into master (f4cf7d3) will increase coverage by 0.71%. The diff coverage is n/a.

:exclamation: Current head 4dd2828 differs from pull request most recent head 4340d8f. Consider uploading reports for the commit 4340d8f to get more accurate results

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   77.76%   78.48%   +0.71%     
==========================================
  Files          37       37              
  Lines       17497    17375     -122     
==========================================
+ Hits        13606    13636      +30     
+ Misses       3891     3739     -152     
Impacted Files Coverage Δ
gap/base/methsel.gd 100.00% <ø> (ø)
gap/perm/largebase.gi 81.60% <0.00%> (-0.77%) :arrow_down:
gap/projective/c6.gi 61.53% <0.00%> (-0.19%) :arrow_down:
gap/matrix/classical.gi 76.54% <0.00%> (-0.16%) :arrow_down:
gap/perm.gi 97.77% <0.00%> (ø)
gap/projective.gi 89.06% <0.00%> (ø)
gap/generic/TrivialGroup.gi 100.00% <0.00%> (ø)
gap/matrix.gi 91.33% <0.00%> (+0.18%) :arrow_up:
gap/projective/c3c5.gi 87.75% <0.00%> (+0.22%) :arrow_up:
gap/base/recognition.gi 71.58% <0.00%> (+0.66%) :arrow_up:
... and 3 more
fingolfin commented 3 years ago

This needs to be rebased

ssiccha commented 3 years ago

we might be better served with a section/chapter describing the overall system, instead of putting all of that into the documentation of a single function

sounds good to me. I'll try to keep it in mind.