search

gap-packages / recog

The GAP package recog to collect methods for constructive recognition
https://gap-packages.github.io/recog/
GNU General Public License v3.0
6 stars 14 forks source link

Improve printing of recog trees #303

Closed ssiccha closed 2 years ago

ssiccha commented 2 years ago

Slightly change how nodes are printed. Previously, the name of the successful method might be appended by a comment string. Now, if there is a comment, it is printed in a separate Comment: field.

Thus also remove the leading underscore of the ri!.comment values.

ssiccha commented 2 years ago

I'll turn Comment : into Comment= for uniformity. Also I need to adjust the test files a little. My son just woke up though. If anyone wants to, feel free to finish this in the mean time.

ssiccha commented 2 years ago

I adjusted the commit, this should work. Tests pass on my machine. Let's see.

codecov[bot] commented 2 years ago

Codecov Report

Merging #303 (a154516) into master (4842ec6) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   78.13%   78.15%   +0.01%     
==========================================
  Files          43       43              
  Lines       18427    18427              
==========================================
+ Hits        14398    14401       +3     
+ Misses       4029     4026       -3
Impacted Files Coverage Δ
gap/base/recognition.gi 69.03% <100.00%> (ø)
gap/projective.gi 83.09% <100.00%> (ø)
gap/projective/almostsimple.gi 66.04% <100.00%> (ø)
gap/projective/almostsimple/lietype.gi 48.04% <100.00%> (ø)
gap/projective/classicalnatural.gi 94.10% <100.00%> (ø)
gap/projective/d247.gi 75.23% <100.00%> (ø)
gap/perm/giant.gi 91.25% <0.00%> (+0.67%) :arrow_up: