gap-packages / recog

The GAP package recog to collect methods for constructive recognition
https://gap-packages.github.io/recog/
GNU General Public License v3.0
6 stars 14 forks source link

Document precisely which methods are implemented *and* used #45

Open fingolfin opened 5 years ago

fingolfin commented 5 years ago

We already made some progress on this by adding comments to source files that give references to papers that are implemented in the file (resp. where we think they are implemented -- some TODO comments here need to be resolved, grep for "probably based on").

But I would like this to be in the code itself -- for each recognition method we install, we should also have a record member that indicates the algorithm implemented there, via a string describing the source (for some of the most basic ones, that could of course be a simple string like "folklore").

Once we have that, we then insert this information automatically into the manual.

fingolfin commented 5 years ago

A good way to produce lots of nice test cases is to take the atlasrep package, then iterate over all the groups in there, and for each group, iterate over its maximal subgroups; and then try recognition on the maximal subgroups. This covers lots of interesting cases and we also have data about the expected isomorphism type resp. the size of those maximal subgroups.

Work on this was started during the GAP Days by @ChrisJefferson et all, and this resulted in RECOG.testAllMaximalSubgroupsOfAtlasGroup. It reveals many, many problems. Before we pursue this further, we need to address some of them, and most importantly, implement mandarins (see issue #85)