search

gap-packages / sgpdec

GAP package for Hierarchical Composition and Decomposition of Permutation Groups and Transformation Semigroups
https://gap-packages.github.io/sgpdec/
Other
18 stars 3 forks source link

Set up Travis CI and Codecov integration #12

Closed olexandr-konovalov closed 5 years ago

egri-nagy commented 5 years ago

Thanks a lot!

olexandr-konovalov commented 5 years ago

Not at all @egri-nagy - you should be able to see that tests failed, so this PR should not be merged.

They failed because digraphs failed to build - perhaps @fingolfin could advice how to fix this? I have specified 

- GAP_PKGS_TO_BUILD="digraphs json io profiling orb semigroups"

but do I need to do anything else?

egri-nagy commented 5 years ago

Yes, I saw digraphs failing. I have 0.13.0 in my gap 4.10 distribution, and that one works.

james-d-mitchell commented 5 years ago

Is there an issue with Digraphs? Can you post a link to the failing build?

olexandr-konovalov commented 5 years ago

@james-d-mitchell I am not sure if this is in digraphs or some adjustment of .travis.yml may be needed. Link to the failing build: https://travis-ci.org/gap-packages/sgpdec/builds/504156628

olexandr-konovalov commented 5 years ago

@egri-nagy good to know that it works elsewhere, but for the efficient use of Travis CI we need to ensure that it works here :)

james-d-mitchell commented 5 years ago

Hmm, looks like maybe this is the fault of Digraphs. It looks like the compiler isn't happy that we are using C99, I think we forgot to add a flag. I'll open a PR to fix this later today if I have time.

olexandr-konovalov commented 5 years ago

OTOH, in the test at https://travis-ci.org/gap-infra/gap-docker-pkg-tests-stable-4.10-devel/jobs/504288569 SgpDec is dropped into the Docker container for the stable-4.10 branch and recent packages - and Digraphs works there (the test fails but for another reason).

egri-nagy commented 5 years ago

I tested it with the 4.10.1 release, and locally on my machine everything works fine.

olexandr-konovalov commented 5 years ago

@egri-nagy Ok, I will submit another PR experimenting with Digraphs build options, but please do not merge it until it will begin to work.