search

gap-packages / sgpdec

GAP package for Hierarchical Composition and Decomposition of Permutation Groups and Transformation Semigroups
https://gap-packages.github.io/sgpdec/
Other
18 stars 3 forks source link

Nehaniv fl - Refactored FLComponents to get FLTransversals #18

Closed nehaniv closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #18 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   95.76%   95.77%   +<.01%     
==========================================
  Files          15       15              
  Lines        2055     2059       +4     
==========================================
+ Hits         1968     1972       +4     
  Misses         87       87
Impacted Files Coverage Δ
lib/fl.gi 100% <100%> (ø) :arrow_up:
egri-nagy commented 5 years ago

Yes, there was no real reason to bundle these two steps together.

This may break some other test that I will fix, and certainly not compatible with the cube paper's code. We need to write an updated paper anyway.

egri-nagy commented 5 years ago

It's not breaking the other tests, that code had been removed before. All good. Thanks!