gap-packages / sgpdec

GAP package for Hierarchical Composition and Decomposition of Permutation Groups and Transformation Semigroups
https://gap-packages.github.io/sgpdec/
Other
18 stars 3 forks source link

Switch CI to use GitHub Actions #20

Closed fingolfin closed 3 years ago

fingolfin commented 3 years ago

This is necessary as Travis CI started to require payment for its services.

codecov[bot] commented 3 years ago

Codecov Report

Merging #20 (140c8eb) into master (2bfd41d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          14       14           
  Lines        2040     2040           
=======================================
  Hits         1991     1991           
  Misses         49       49           
fingolfin commented 3 years ago

@egri-nagy the tests in wreath.tst for GroupWreathProduct fail in GAP 4.11 and GAP master. Indeed:

gap> A:=Z2;; B:=Z2;; C:=Z3;;
gap> AB := Image(IsomorphismPermGroup(GroupWreathProduct([A,B])));;
gap> BC := Image(IsomorphismPermGroup(GroupWreathProduct([B,C])));;
gap> ABC := Image(IsomorphismPermGroup(GroupWreathProduct([A,B,C])));
<permutation group of size 648 with 3 generators>
gap> AB_C := Image(IsomorphismPermGroup(GroupWreathProduct([AB,C])));
<permutation group of size 52488 with 3 generators>
gap> A_BC := Image(IsomorphismPermGroup(GroupWreathProduct([A,BC])));
<permutation group of size 648 with 3 generators>

Any idea ?

fingolfin commented 3 years ago

Ah I now see this is in issue #19.

we could run git bisect on GAP to figure out which on caused it to regress. That might at least give a hint.

egri-nagy commented 3 years ago

Thank you for the GitHub Actions migrations. I was not up-to-date with the Travis CI's new business model.

As for the problem with the GroupWreathProduct, I'll have a closer look.I hope it will not get to bisecting. :)