search

gap-packages / sgpdec

GAP package for Hierarchical Composition and Decomposition of Permutation Groups and Transformation Semigroups
https://gap-packages.github.io/sgpdec/
Other
18 stars 3 forks source link

Implemented correct chaining algorithm; API change; Updated testing. #28

Closed thomasgaozx closed 3 months ago

egri-nagy commented 3 months ago

The test fails for MaxChainOfEssentialDependency, the output seems to be changed, or debugging message remained. Please run SgpDecTestInstall(); before commits.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.82%. Comparing base (66ad07f) to head (8153f0c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #28 +/- ## ========================================== + Coverage 96.71% 96.82% +0.11% ========================================== Files 44 44 Lines 3040 3053 +13 ========================================== + Hits 2940 2956 +16 + Misses 100 97 -3 ``` | [Files](https://app.codecov.io/gh/gap-packages/sgpdec/pull/28?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages) | Coverage Δ | | |---|---|---| | [lib/lowerbound.gd](https://app.codecov.io/gh/gap-packages/sgpdec/pull/28?src=pr&el=tree&filepath=lib%2Flowerbound.gd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages#diff-bGliL2xvd2VyYm91bmQuZ2Q=) | `100.00% <100.00%> (ø)` | | | [lib/lowerbound.gi](https://app.codecov.io/gh/gap-packages/sgpdec/pull/28?src=pr&el=tree&filepath=lib%2Flowerbound.gi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages#diff-bGliL2xvd2VyYm91bmQuZ2k=) | `95.40% <95.83%> (+4.86%)` | :arrow_up: |