search

gap-packages / smallsemi

A library of small semigroups
https://gap-packages.github.io/smallsemi/
GNU General Public License v3.0
3 stars 3 forks source link

Declare IsSemigroupWithClosedIdempotents only when needed, and for all semigroups #4

Closed wilfwilson closed 5 years ago

wilfwilson commented 5 years ago

Alternative to #3 to address problem raised in https://github.com/gap-packages/Semigroups/pull/605.

olexandr-konovalov commented 5 years ago

Thanks @wilfwilson! Perhaps we need to add setup for Travis and Codecov first, and then rebase this PR to test it properly.

fingolfin commented 5 years ago

I submitted PR #5 which adds Travis support. Once that is merged, this PR could be rebased.

fingolfin commented 5 years ago

@wilfwilson could you rebase this, please?

wilfwilson commented 5 years ago

Rebased.

james-d-mitchell commented 5 years ago

Thanks all

codecov[bot] commented 5 years ago

Codecov Report

Merging #4 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage    83.4%   83.41%   +<.01%     
==========================================
  Files          13       13              
  Lines        3350     3352       +2     
==========================================
+ Hits         2794     2796       +2     
  Misses        556      556
Impacted Files Coverage Δ
gap/properties.gd 100% <100%> (ø) :arrow_up:
codecov[bot] commented 5 years ago

Codecov Report

Merging #4 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage    83.4%   83.41%   +<.01%     
==========================================
  Files          13       13              
  Lines        3350     3352       +2     
==========================================
+ Hits         2794     2796       +2     
  Misses        556      556
Impacted Files Coverage Δ
gap/properties.gd 100% <100%> (ø) :arrow_up:
codecov[bot] commented 5 years ago

Codecov Report

Merging #4 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage    83.4%   83.41%   +<.01%     
==========================================
  Files          13       13              
  Lines        3350     3352       +2     
==========================================
+ Hits         2794     2796       +2     
  Misses        556      556
Impacted Files Coverage Δ
gap/properties.gd 100% <100%> (ø) :arrow_up: