Closed fingolfin closed 1 year ago
I basically got rid of all uses of Elements
. BTW that function is a synonym for AsSet
. And you also use AsSet
, so perhaps some of those could be inspected as well
oops, that was a bit of a hasty merge! The CI tests failed, i.e. something was wrong with this PR. I'll look into fixing it now but I recommend not merging changes while their cause CI failures :-)
Aha but the failure actually seems to not be caused by this PR, but by some other prior changes, so all is good, maybe
Before this, I observed this:
As a result, the CI tests timed out, because this test took many minutes:
With this PR, that line takes just 2.5 seconds on my machine.