gap-packages / sotgrps

https://gap-packages.github.io/sotgrps/
GNU General Public License v2.0
2 stars 1 forks source link

Fix tests #28

Closed fingolfin closed 1 year ago

fingolfin commented 1 year ago

@xpan-eileen this fix is not nice but it's what we need: the tests are always run as if GAP was executed in a terminal set to a width of 80 characters, and GAP then automatically wraps the printed output... there are some things one can do to make this a little bit nicer, but doing this everywhere will be quite a bit of work, so let's do this for now.

fingolfin commented 1 year ago

BTW I got this fix by modifying tst/testall.g and adding rewriteToFile:=true to the testOptions.

fingolfin commented 1 year ago

oh actually I think I can make it at least a bit nicer, wait a moment (we should wait anyway to verify it fixes the CI tests)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.50 :tada:

Comparison is base (fb5d50b) 94.25% compared to head (22a3e93) 94.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #28 +/- ## ========================================== + Coverage 94.25% 94.76% +0.50% ========================================== Files 21 21 Lines 7920 7923 +3 ========================================== + Hits 7465 7508 +43 + Misses 455 415 -40 ``` | [Impacted Files](https://app.codecov.io/gh/xpan-eileen/sotgrps/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [gap/SOTGrps.gd](https://app.codecov.io/gh/xpan-eileen/sotgrps/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Z2FwL1NPVEdycHMuZ2Q=) | `100.00% <ø> (ø)` | | | [gap/IdFunc.gi](https://app.codecov.io/gh/xpan-eileen/sotgrps/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Z2FwL0lkRnVuYy5naQ==) | `95.27% <100.00%> (+0.43%)` | :arrow_up: | | [gap/IdFuncP4Q.gi](https://app.codecov.io/gh/xpan-eileen/sotgrps/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Z2FwL0lkRnVuY1A0US5naQ==) | `98.27% <100.00%> (+0.64%)` | :arrow_up: | | [gap/SOTGrps.gi](https://app.codecov.io/gh/xpan-eileen/sotgrps/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Z2FwL1NPVEdycHMuZ2k=) | `84.91% <100.00%> (+0.93%)` | :arrow_up: | | [gap/SOTinfo.gi](https://app.codecov.io/gh/xpan-eileen/sotgrps/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Z2FwL1NPVGluZm8uZ2k=) | `67.91% <100.00%> (ø)` | | | [tst/test.gi](https://app.codecov.io/gh/xpan-eileen/sotgrps/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dHN0L3Rlc3QuZ2k=) | `46.96% <100.00%> (+1.50%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/xpan-eileen/sotgrps/pull/28/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

fingolfin commented 1 year ago

Because we run the tests with an option that tells it to ignore whitespace, we can actually undo the line breaks inserted by GAP resp. by rewriteToFile:=true, and see that the actual problem was a missing . ;-)

xpan-eileen commented 1 year ago

Thanks! The punctuation also just was wrong, so I am gonna change it a bit more...

fingolfin commented 1 year ago

By the way, this is also why for GAP we do all development through PRs, we never push directly to the master branch: this way, CI tests are run on all tests, including those which "surely cannot break anything" (and then inevitably break something after all ;-) )