Closed fingolfin closed 1 year ago
BTW I got this fix by modifying tst/testall.g
and adding rewriteToFile:=true
to the testOptions
.
oh actually I think I can make it at least a bit nicer, wait a moment (we should wait anyway to verify it fixes the CI tests)
Patch coverage: 100.00
% and project coverage change: +0.50
:tada:
Comparison is base (
fb5d50b
) 94.25% compared to head (22a3e93
) 94.76%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Because we run the tests with an option that tells it to ignore whitespace, we can actually undo the line breaks inserted by GAP resp. by rewriteToFile:=true
, and see that the actual problem was a missing .
;-)
Thanks! The punctuation also just was wrong, so I am gonna change it a bit more...
By the way, this is also why for GAP we do all development through PRs, we never push directly to the master branch: this way, CI tests are run on all tests, including those which "surely cannot break anything" (and then inevitably break something after all ;-) )
@xpan-eileen this fix is not nice but it's what we need: the tests are always run as if GAP was executed in a terminal set to a width of 80 characters, and GAP then automatically wraps the printed output... there are some things one can do to make this a little bit nicer, but doing this everywhere will be quite a bit of work, so let's do this for now.