search

gap-packages / sotgrps

https://gap-packages.github.io/sotgrps/
GNU General Public License v2.0
2 stars 1 forks source link

Oddity in pqrs code #38

Closed fingolfin closed 1 year ago

fingolfin commented 1 year ago

The code in pqrs.gi has many lines of the form

        Add(all, [ [p, q, r, s], ..... ]);

But in line 178 (and again in its "twin" in line 371), it says: [p, r, q, s]

Now, I am guessing this is intentional, and explained somewhere in your thesis or in your paper; but it at least is surprising when seeing it. So I think it would be helpful to at least add a comment stating that it is intentional, and providing a citation pointing at an explanation.

(Of course if this is not intentional it should also be resolved ;-) )

xpan-eileen commented 1 year ago

There was actually no important reason why they had to be in that order. Just changed them into the usual order [p, q, r, s] now.