Closed fingolfin closed 12 months ago
@xpan-eileen OK this is now ready from my point of view (assuming the test suite passes, let's wait for that)
Merging #49 (03ffe6d) into master (3e8ba15) will increase coverage by
0.26%
. The diff coverage is90.90%
.
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 98.09% 98.35% +0.26%
==========================================
Files 21 21
Lines 7701 7727 +26
==========================================
+ Hits 7554 7600 +46
+ Misses 147 127 -20
Files Changed | Coverage Δ | |
---|---|---|
gap/SOTGrps.gd | 100.00% <ø> (ø) |
|
gap/sot.gi | 89.09% <ø> (-0.63%) |
:arrow_down: |
gap/SOTinfo.gi | 96.42% <90.47%> (+1.52%) |
:arrow_up: |
gap/SOTGrps.gi | 95.65% <91.80%> (+9.76%) |
:arrow_up: |
@xpan-eileen OK to merge this?
Cleanup the function, ensure output is consistent across all cases, and add somewhat more systematic tests.
Also add an internal version that does not print the initial line (for later use in SmallGroupsInformation).
Also add some other internal functions which avoid some more repeated factoring of the same integers.