gap-packages / sotgrps

https://gap-packages.github.io/sotgrps/
GNU General Public License v2.0
2 stars 1 forks source link

Basic integration with the small groups library #50

Closed fingolfin closed 11 months ago

fingolfin commented 1 year ago

This PR implements the first part of issue #35: it provides a new layer for the small groups library that enables handling of orders covered by SOTGrps but not by the SmallGrps package.

This is contains and is based on #49 (in fact working on this PR motivated PR #49), but only in order to get nicer output for SmallGroupsInformation. Without that PR, the only change here is that a few tests will have slightly different output.

Please do not merge this before we have settled #49.

Also, I think this feature (extending the SmallGroupsLibrary) should be documented in the package manual.

codecov[bot] commented 1 year ago

Codecov Report

Merging #50 (8da4354) into master (7b1efca) will decrease coverage by 0.01%. The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files          21       22       +1     
  Lines        8056     8095      +39     
==========================================
+ Hits         7928     7966      +38     
- Misses        128      129       +1     
Files Changed Coverage Δ
gap/SOTGrps.gd 100.00% <ø> (ø)
gap/Integration.gi 96.96% <94.44%> (ø)
PackageInfo.g 100.00% <100.00%> (ø)
read.g 100.00% <100.00%> (ø)

:loudspeaker: Have feedback on the report? Share it here.

fingolfin commented 12 months ago

@xpan-eileen this now ready from my point of view, please have a look.

xpan-eileen commented 12 months ago

Great thanks for that! Just please give me a day or two.

fingolfin commented 12 months ago

No need to hurry :-)