gap-packages / unitlib

UnitLib - library of normalized unit groups of modular group algebras
https://gap-packages.github.io/unitlib
GNU General Public License v2.0
1 stars 2 forks source link

gzip files are supported in Windows with GAP >= 4.10 #17

Closed fingolfin closed 3 years ago

olexandr-konovalov commented 3 years ago

This needs further adjustment. I've tried it on Windows in GAP 4.11.0, and it complains that 'gunzip' is not recognised. Indeed, just below the block you've removed we have

  gzfile := Concatenation( 
               GAPInfo.PackagesInfo.("unitlib")[1].InstallationPath,
               "/data/128/", filename, ".g.gz" );
  libfile := Filename( DirectoryTemporary(), "filename");
  Exec( Concatenation( "gunzip -c ", gzfile, " > ", libfile ) );

what now could be made in a better way.

fingolfin commented 3 years ago

Indeed, the whole extraction code ought to be simplified or even removed. Good to have CI tests again

codecov[bot] commented 3 years ago

Codecov Report

Merging #17 (94bac34) into master (a02a430) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   73.89%   73.95%   +0.06%     
==========================================
  Files         343      343              
  Lines         590      576      -14     
==========================================
- Hits          436      426      -10     
+ Misses        154      150       -4     
Impacted Files Coverage Δ
lib/unitlib.g 81.11% <100.00%> (+1.30%) :arrow_up:
fingolfin commented 3 years ago

Updated

fingolfin commented 3 years ago

Argh! OK, updated once again

olexandr-konovalov commented 3 years ago

Dealing with the legacy code is hard... even when it's your own code...

olexandr-konovalov commented 3 years ago

@fingolfin Aargh the limitation for order 128 it's also in README and perhaps in the documentation! I will deal with it myself.

fingolfin commented 3 years ago

Sorry - I should habe grepped for 128! :-(