search

gap-packages / unitlib

UnitLib - library of normalized unit groups of modular group algebras
https://gap-packages.github.io/unitlib
GNU General Public License v2.0
1 stars 2 forks source link

Adapt to LAGUNA changes #24

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

See https://github.com/gap-packages/laguna/pull/27

CC @alex-konovalov

codecov[bot] commented 2 years ago

Codecov Report

Merging #24 (08c4bcd) into master (eb1dc3a) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   73.95%   73.95%           
=======================================
  Files         343      343           
  Lines         576      576           
=======================================
  Hits          426      426           
  Misses        150      150
Impacted Files Coverage Δ
lib/parunits.g 5.00% <0.00%> (ø)
lib/unitlib.g 81.11% <100.00%> (ø)
olexandr-konovalov commented 2 years ago

@fingolfin hmm, what are those problems in stable branches?

fingolfin commented 2 years ago

Huh, weird... no idea right now. Gotta investigate...

olexandr-konovalov commented 2 years ago

Starts with

#I  UnitLib package is not available. To see further details, enter
#I  SetInfoLevel(InfoPackageLoading,4); and try to load the package again.

but why?

olexandr-konovalov commented 2 years ago

@fingolfin of course, it asks LAGUNA 3.9.4 from Feb 2022. What to do? a) don't test with GAP 4.10 b) how soon 3.9.4 will appear for GAP 4.11 ?

fingolfin commented 2 years ago

Not sure what you mean with "how soon 3.9.4 will appear for GAP 4.11".

Perhaps: "when will the GAP 4.11 branch be switched to using the new package distribution" ? That's a good question, I guess. I could do that right now.

olexandr-konovalov commented 2 years ago

Yes, exactly what I had in mind. Sometimes I write too short always counting on your abilities to read my mind :)

fingolfin commented 2 years ago

Updating the package distro for 4.11 is done in https://github.com/gap-system/gap/pull/4845 which needs to be approved by someone... :-)

olexandr-konovalov commented 2 years ago

@fingolfin so, after https://github.com/gap-system/gap/pull/4845 merged, can we re-run this PR's CI to check that it works?

fingolfin commented 2 years ago

Done. The 4.11 tests pass now. The 4.10 ones still fail. I guess should just require GAP >= 4.11

olexandr-konovalov commented 2 years ago

@fingolfin ok, happy go require 4.11, thanks!