search

gap-packages / walrus

Computational Methods for Finitely Generated Monoids and Groups
https://gap-packages.github.io/walrus
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Rename Vertex to WalrusVertex #35

Closed RussWoodroofe closed 2 years ago

RussWoodroofe commented 3 years ago

Per my prior comment, the name Vertex conflicts with xgap, and prevents loading Walrus on xgap or Gap.app. This patch just renames Vertex to WalrusVertex. I don't think that Vertex is even documented, so I don't expect that this causes any trouble. I'm already shipping this patch in Gap.app.

Since none of the walrus commands with Vertex in their name seem to be documented, I would further suggest that they all be renamed following a similar style (e.g., VertexFor -> WalrusVertexFor). But as I'm not certain that wouldn't cause trouble, this PR does not implement that bigger change.

fingolfin commented 2 years ago

I am not sure this is the way to go. Other packages may want to define Vertex, too. Usually the solution in such cases is to turn the function into an operation, and then the various packages have their own declarations and method installations...